Alex Behm has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9564 )

Change subject: IMPALA-6619: Incorrect partitions in RECOVER PARTITIONS
......................................................................


Patch Set 5: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9564/3/tests/metadata/test_recover_partitions.py
File tests/metadata/test_recover_partitions.py:

http://gerrit.cloudera.org:8080/#/c/9564/3/tests/metadata/test_recover_partitions.py@343
PS3, Line 343:   @SkipIfLocal.hdfs_client
> I'm just following all other test methods here. According to https://github
My understanding is that  @SkipIfLocal.hive means Hive's HiveServer2 is not 
started so running queries against Hive does not work. The Hive Metastore is 
certainly started, otherwise most tests would be pointless (nothing works 
without the Hive Metastore).

My understanding of @SkipIfLocal.hdfs_client is that hdfs_client python will 
not work. However, none of those calls are used here.

Basically, I think that several of the SkipIfLocal in this file might be wrong.

I'm ok with checking this in as is, but can you please investigate this further 
and file a JIRA to clean this up if necessary? Thanks.



--
To view, visit http://gerrit.cloudera.org:8080/9564
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If45d78d095a5d3e85ebf61722566136d17825559
Gerrit-Change-Number: 9564
Gerrit-PatchSet: 5
Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com>
Gerrit-Comment-Date: Tue, 13 Mar 2018 22:16:58 +0000
Gerrit-HasComments: Yes

Reply via email to