Alex Behm has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9564 )

Change subject: IMPALA-6619: Incorrect partitions in RECOVER PARTITIONS
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/9564/3/tests/metadata/test_recover_partitions.py
File tests/metadata/test_recover_partitions.py:

http://gerrit.cloudera.org:8080/#/c/9564/3/tests/metadata/test_recover_partitions.py@343
PS3, Line 343:   @SkipIfLocal.hdfs_client
Which part doesn't work on the local FS?


http://gerrit.cloudera.org:8080/#/c/9564/3/tests/metadata/test_recover_partitions.py@399
PS3, Line 399:     return self.count_value('hdfs://', lines)
This won't work on s3 because there is no "hdfs://"

Take a look at filesystem_utils.py FILESYSTEM_PREFIX



--
To view, visit http://gerrit.cloudera.org:8080/9564
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If45d78d095a5d3e85ebf61722566136d17825559
Gerrit-Change-Number: 9564
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com>
Gerrit-Comment-Date: Tue, 13 Mar 2018 21:21:06 +0000
Gerrit-HasComments: Yes

Reply via email to