Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9589 )
Change subject: IMPALA-6643: Add REFRESH fine-grained privilege ...................................................................... Patch Set 15: (3 comments) http://gerrit.cloudera.org:8080/#/c/9589/15/fe/src/main/java/org/apache/impala/authorization/Privilege.java File fe/src/main/java/org/apache/impala/authorization/Privilege.java: http://gerrit.cloudera.org:8080/#/c/9589/15/fe/src/main/java/org/apache/impala/authorization/Privilege.java@52 PS15, Line 52: public enum SentryAction implements Action { > Privilege enum may contain a collection of Sentry actions, for instance VIE I see. So this 1:N mapping may go away as we add more fine-grained privileges? We should be sure to do that refactoring when the time comes. http://gerrit.cloudera.org:8080/#/c/9589/17/fe/src/main/java/org/apache/impala/authorization/Privilege.java File fe/src/main/java/org/apache/impala/authorization/Privilege.java: http://gerrit.cloudera.org:8080/#/c/9589/17/fe/src/main/java/org/apache/impala/authorization/Privilege.java@36 PS17, Line 36: VIEW_METADATA(EnumSet.of(SentryAction.INSERT, SentryAction.SELECT), true), REFRESH does not allow inspecting the metadata? That seems particularly odd since REFRESH is for updating the metadata. http://gerrit.cloudera.org:8080/#/c/9589/15/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java File fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java: http://gerrit.cloudera.org:8080/#/c/9589/15/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java@266 PS15, Line 266: roleName = "refresh_functional_alltypes"; > It's because of the existing test case: https://github.com/apache/impala/bl Why is it not sufficient to only have refresh_functional_alltypes? Why do we also need refresh_functional_alltypesagg? -- To view, visit http://gerrit.cloudera.org:8080/9589 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c3c5a51fe493d39fd719c7a388d4d5760049ce4 Gerrit-Change-Number: 9589 Gerrit-PatchSet: 15 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Adam Holley <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Tue, 20 Mar 2018 01:21:33 +0000 Gerrit-HasComments: Yes
