Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/9589 )
Change subject: IMPALA-6643: Add REFRESH fine-grained privilege ...................................................................... Patch Set 17: (2 comments) http://gerrit.cloudera.org:8080/#/c/9589/15/fe/src/main/java/org/apache/impala/authorization/Privilege.java File fe/src/main/java/org/apache/impala/authorization/Privilege.java: http://gerrit.cloudera.org:8080/#/c/9589/15/fe/src/main/java/org/apache/impala/authorization/Privilege.java@52 PS15, Line 52: public enum SentryAction implements Action { > I see. So this 1:N mapping may go away as we add more fine-grained privileg Yup, I'll definitely keep that in mind. http://gerrit.cloudera.org:8080/#/c/9589/15/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java File fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java: http://gerrit.cloudera.org:8080/#/c/9589/15/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java@266 PS15, Line 266: roleName = "refresh_functional_alltypes"; > Why is it not sufficient to only have refresh_functional_alltypes? Why do w Unfortunately there are existing tests that also rely on functional.alltypesagg: https://github.com/apache/impala/blob/master/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java#L804-L805. I can refactor those tests to only use one table if you prefer that. Looking at existing TestResetMetadata, there's only one place that uses functional.alltypes: https://github.com/apache/impala/blob/master/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java#L810. Should I just remove that test so that I can also remove the refresh_functional_alltypes role. I believe that test has already been covered by: https://github.com/apache/impala/blob/master/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java#L809 -- To view, visit http://gerrit.cloudera.org:8080/9589 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c3c5a51fe493d39fd719c7a388d4d5760049ce4 Gerrit-Change-Number: 9589 Gerrit-PatchSet: 17 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Adam Holley <g...@holleyism.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Tue, 20 Mar 2018 01:38:25 +0000 Gerrit-HasComments: Yes
