Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9738 )
Change subject: IMPALA-6674: Add CREATE fine-grained privilege ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/9738/5/fe/src/main/java/org/apache/impala/analysis/DropFunctionStmt.java File fe/src/main/java/org/apache/impala/analysis/DropFunctionStmt.java: http://gerrit.cloudera.org:8080/#/c/9738/5/fe/src/main/java/org/apache/impala/analysis/DropFunctionStmt.java@88 PS5, Line 88: // For now, if authorization is enabled, the user needs ALL on the server : // to drop functions. : // TODO: this is not the right granularity but acceptable for now. Update comment. http://gerrit.cloudera.org:8080/#/c/9738/5/fe/src/main/java/org/apache/impala/authorization/AuthorizeableFn.java File fe/src/main/java/org/apache/impala/authorization/AuthorizeableFn.java: http://gerrit.cloudera.org:8080/#/c/9738/5/fe/src/main/java/org/apache/impala/authorization/AuthorizeableFn.java@50 PS5, Line 50: pu nit: add @Override http://gerrit.cloudera.org:8080/#/c/9738/5/fe/src/main/java/org/apache/impala/authorization/AuthorizeableFn.java@52 PS5, Line 52: getFnName I don't see where this is ever used. -- To view, visit http://gerrit.cloudera.org:8080/9738 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id540e78fc9201fc1b4e6cac9b81ea54b8ae9eecd Gerrit-Change-Number: 9738 Gerrit-PatchSet: 5 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Adam Holley <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Comment-Date: Wed, 21 Mar 2018 22:15:56 +0000 Gerrit-HasComments: Yes
