Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9738 )
Change subject: IMPALA-6647: Add CREATE fine-grained privilege ...................................................................... Patch Set 16: (1 comment) lgtm after this final change http://gerrit.cloudera.org:8080/#/c/9738/16/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java File fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java: http://gerrit.cloudera.org:8080/#/c/9738/16/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java@2525 PS16, Line 2525: AnalysisContext ctx = createAnalysisCtx(ctx_.authzConfig, USER.getName()); You don't need this, and leaving it is confusing. We rely on ctx_ for the AuthzOk() and AuthzError() functoins by default. -- To view, visit http://gerrit.cloudera.org:8080/9738 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id540e78fc9201fc1b4e6cac9b81ea54b8ae9eecd Gerrit-Change-Number: 9738 Gerrit-PatchSet: 16 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Adam Holley <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Comment-Date: Fri, 23 Mar 2018 04:10:52 +0000 Gerrit-HasComments: Yes
