Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9738 )
Change subject: IMPALA-6647: Add CREATE fine-grained privilege ...................................................................... Patch Set 15: (1 comment) Almost good to go http://gerrit.cloudera.org:8080/#/c/9738/15/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java File fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java: http://gerrit.cloudera.org:8080/#/c/9738/15/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java@1183 PS15, Line 1183: if (ctx_.authzConfig.isFileBasedPolicy()) return; There's a lot of common boilerplate in these new server-level-create tests. How about we factor it out into a new test, something like: TestServerLevelCreate() or similar We should test the cases: * create db * create function in existing db * create table in existing db * create view in existing db * CTAS fails -- To view, visit http://gerrit.cloudera.org:8080/9738 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id540e78fc9201fc1b4e6cac9b81ea54b8ae9eecd Gerrit-Change-Number: 9738 Gerrit-PatchSet: 15 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Adam Holley <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Comment-Date: Thu, 22 Mar 2018 23:29:28 +0000 Gerrit-HasComments: Yes
