Nithya Janarthanan has posted comments on this change. ( http://gerrit.cloudera.org:8080/9385 )
Change subject: IMPALA-4430: Update build scripts to die hard when IMPALA_HOME has spaces ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/9385/5/bin/impala-config.sh File bin/impala-config.sh: http://gerrit.cloudera.org:8080/#/c/9385/5/bin/impala-config.sh@48 PS5, Line 48: "'$IMPALA_HOME'" =~ [[:blank:]] > See below on where to put this, but that said, make sure any checks you use [[:blank:]] seems to be zsh compliant based on below documentation https://www.gnu.org/software/grep/manual/html_node/Character-Classes-and-Bracket-Expressions.html http://zsh.sourceforge.net/Doc/Release/Expansion.html http://gerrit.cloudera.org:8080/#/c/9385/5/bin/impala-config.sh@56 PS5, Line 56: else : echo "IMPALA_HOME cannot have spaces in the path" : exit 1 : fi > Not sure it makes sense to put this check here. The L56 condition needs to Since it is possible that IMPALA_HOME could still expand to a path with spaces, moving the space check after this block http://gerrit.cloudera.org:8080/#/c/9385/5/buildall.sh File buildall.sh: http://gerrit.cloudera.org:8080/#/c/9385/5/buildall.sh@28 PS5, Line 28: $ > I don't think you want variable expansion here. Done -- To view, visit http://gerrit.cloudera.org:8080/9385 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I08b3d2b3f3e14c568d1672ee86ff2c52e8017b81 Gerrit-Change-Number: 9385 Gerrit-PatchSet: 5 Gerrit-Owner: Nithya Janarthanan <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Nithya Janarthanan <[email protected]> Gerrit-Comment-Date: Fri, 30 Mar 2018 18:21:31 +0000 Gerrit-HasComments: Yes
