Nithya Janarthanan has posted comments on this change. ( http://gerrit.cloudera.org:8080/9385 )
Change subject: IMPAL-4430: Update build scripts to die hard when IMPALA_HOME has spaces ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/9385/2/buildall.sh File buildall.sh: http://gerrit.cloudera.org:8080/#/c/9385/2/buildall.sh@23 PS2, Line 23: if [[ ( "'$PWD'" =~ [[:blank:]] ) || ("'$IMPALA_HOME'" =~ [[:blank:]] ) ]] > Yes. This should work since it checks $ROOT to not have space which is then Done http://gerrit.cloudera.org:8080/#/c/9385/2/buildall.sh@25 PS2, Line 25: Excuting directory/IMPALA_HOME > Yes...will fix the comment Done -- To view, visit http://gerrit.cloudera.org:8080/9385 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I08b3d2b3f3e14c568d1672ee86ff2c52e8017b81 Gerrit-Change-Number: 9385 Gerrit-PatchSet: 2 Gerrit-Owner: Nithya Janarthanan <njanartha...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Nithya Janarthanan <njanartha...@cloudera.com> Gerrit-Comment-Date: Thu, 01 Mar 2018 18:27:30 +0000 Gerrit-HasComments: Yes
