David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9385 )
Change subject: IMPALA-4430: Update build scripts to die hard when IMPALA_HOME has spaces ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/9385/5/buildall.sh File buildall.sh: http://gerrit.cloudera.org:8080/#/c/9385/5/buildall.sh@28 PS5, Line 28: $ I don't think you want variable expansion here. -- To view, visit http://gerrit.cloudera.org:8080/9385 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I08b3d2b3f3e14c568d1672ee86ff2c52e8017b81 Gerrit-Change-Number: 9385 Gerrit-PatchSet: 5 Gerrit-Owner: Nithya Janarthanan <njanartha...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Nithya Janarthanan <njanartha...@cloudera.com> Gerrit-Comment-Date: Fri, 02 Mar 2018 21:28:34 +0000 Gerrit-HasComments: Yes
