Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/9927 )
Change subject: IMPALA-6805: Show current database in Impala shell prompt ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/9927/2/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/9927/2/shell/impala_shell.py@777 PS2, Line 777: [%s:%s] %s I would prefer to change this to use the format() function. Something like "[{host}:{port}] {db}> ".format(host=self.impalad[0], port=self.impalad[1], db =... http://gerrit.cloudera.org:8080/#/c/9927/2/shell/impala_shell.py@1147 PS2, Line 1147: [%s:%s] %s> Since this is used several times, this template should be a constant declared somewhere around line 137. http://gerrit.cloudera.org:8080/#/c/9927/2/tests/shell/test_shell_interactive.py File tests/shell/test_shell_interactive.py: http://gerrit.cloudera.org:8080/#/c/9927/2/tests/shell/test_shell_interactive.py@62 PS2, Line 62: %s>" % db it's better to use format() here too. -- To view, visit http://gerrit.cloudera.org:8080/9927 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifb0ae58507321e426e5f0f16518671420974a3fc Gerrit-Change-Number: 9927 Gerrit-PatchSet: 2 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-Comment-Date: Wed, 04 Apr 2018 22:03:25 +0000 Gerrit-HasComments: Yes
