David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9927 )
Change subject: IMPALA-6805: Show current database in Impala shell prompt ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/9927/2/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/9927/2/shell/impala_shell.py@1147 PS2, Line 1147: [%s:%s] %s> > Since this is used several times, this template should be a constant declar Good suggestion. Note L108: DISCONNECTED_PROMPT = "[Not connected] > " -- To view, visit http://gerrit.cloudera.org:8080/9927 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifb0ae58507321e426e5f0f16518671420974a3fc Gerrit-Change-Number: 9927 Gerrit-PatchSet: 2 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Comment-Date: Wed, 04 Apr 2018 22:09:04 +0000 Gerrit-HasComments: Yes
