Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/9927 )
Change subject: IMPALA-6805: Show current database in Impala shell prompt ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/9927/3/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/9927/3/shell/impala_shell.py@1151 PS3, Line 1151: strip('`') why do we strip() here, but not on line 781? http://gerrit.cloudera.org:8080/#/c/9927/3/shell/impala_shell.py@1153 PS3, Line 1153: # args == current_db means -d option was passed but the database does not exist. It's confusing to me why args == current_db means that the db does not exist. Can you explain this a little better? What are the contents of args and current_db? -- To view, visit http://gerrit.cloudera.org:8080/9927 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifb0ae58507321e426e5f0f16518671420974a3fc Gerrit-Change-Number: 9927 Gerrit-PatchSet: 3 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Comment-Date: Wed, 04 Apr 2018 23:43:57 +0000 Gerrit-HasComments: Yes
