Fredy Wijaya has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/9933


Change subject: IMPALA-2195: Improper handling of comments in queries
......................................................................

IMPALA-2195: Improper handling of comments in queries

This patch fixes an issue where parseline is unable to determine the
correct command when a statement has a trailing comment.

An example where the patch fixes the due to incorrect command in
parseline.

Before:
> -- comment
> insert into table t values(100);
Fetched 1 row(s) in 0.01s

After:
> -- comment
> insert into table t values(100);
Modified 1 row(s) in 0.01s

Testing:
- Added shell tests
- Ran end-to-end shell tests

Change-Id: I7ac7cb5a30e6dda73ebe761d9f0eb9ba038e14a7
---
M shell/impala_shell.py
M tests/shell/test_shell_interactive.py
2 files changed, 19 insertions(+), 6 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/33/9933/1
--
To view, visit http://gerrit.cloudera.org:8080/9933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7ac7cb5a30e6dda73ebe761d9f0eb9ba038e14a7
Gerrit-Change-Number: 9933
Gerrit-PatchSet: 1
Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com>

Reply via email to