Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9933 )
Change subject: IMPALA-2195: Improper handling of comments in queries ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/9933/2/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/9933/2/shell/impala_shell.py@1279 PS2, Line 1279: line = sqlparse.format(line.strip(), strip_comments=True).encode('utf-8') > looks like this strips the query hints too? (Users can provide query hints Would also be good to look how often we parse this string. IIRC, we invoke sqlparse quite a few times, and it's not exactly cheap. Perhaps we can parse it once and reuse the result in the various relevant places. -- To view, visit http://gerrit.cloudera.org:8080/9933 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ac7cb5a30e6dda73ebe761d9f0eb9ba038e14a7 Gerrit-Change-Number: 9933 Gerrit-PatchSet: 2 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Comment-Date: Thu, 05 Apr 2018 15:51:13 +0000 Gerrit-HasComments: Yes
