Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/9951 )
Change subject: IMPALA-6824: Fix crash in RuntimeProfile::EventSequence::AddNewerEvents() ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9951/1/be/src/util/runtime-profile-counters.h File be/src/util/runtime-profile-counters.h: http://gerrit.cloudera.org:8080/#/c/9951/1/be/src/util/runtime-profile-counters.h@348 PS1, Line 348: events_.reserve(events_.size() + timestamps.size()); This will over reserve, if there are timestamps <= last_timestamp. As 'timestamps' is sorted, a for loop could count till the first element to append, reserve the exact size, and the next for loop could simply push_back the rest. -- To view, visit http://gerrit.cloudera.org:8080/9951 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I76d30517544e8aa40e7d041f6a65a5dd361ae3c1 Gerrit-Change-Number: 9951 Gerrit-PatchSet: 1 Gerrit-Owner: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Comment-Date: Mon, 09 Apr 2018 14:49:49 +0000 Gerrit-HasComments: Yes
