Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9951 )

Change subject: IMPALA-6824: Fix crash in 
RuntimeProfile::EventSequence::AddNewerEvents()
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9951/1/be/src/util/runtime-profile-counters.h
File be/src/util/runtime-profile-counters.h:

http://gerrit.cloudera.org:8080/#/c/9951/1/be/src/util/runtime-profile-counters.h@348
PS1, Line 348:     events_.reserve(events_.size() + timestamps.size());
> This will over reserve, if there are timestamps <= last_timestamp. As 'time
Let's not bother reserving, this code isn't perf critical so it doesn't really 
matter if there's an extra malloc() call or two - doesn't seem worth the 
complication.



--
To view, visit http://gerrit.cloudera.org:8080/9951
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I76d30517544e8aa40e7d041f6a65a5dd361ae3c1
Gerrit-Change-Number: 9951
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <l...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Comment-Date: Mon, 09 Apr 2018 16:06:47 +0000
Gerrit-HasComments: Yes

Reply via email to