Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/9960 )
Change subject: IMPALA-6120: Add thread timers for reporting codegen time ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/9960/1/be/src/codegen/llvm-codegen.h File be/src/codegen/llvm-codegen.h: http://gerrit.cloudera.org:8080/#/c/9960/1/be/src/codegen/llvm-codegen.h@761 PS1, Line 761: RuntimeProfile::Counter* optimization_timer_; > If we switch to having the counter updated outside of this class, lets docu Done http://gerrit.cloudera.org:8080/#/c/9960/1/be/src/codegen/llvm-codegen.h@779 PS1, Line 779: > If we switch to having the counter updated outside of this class, lets docu Done http://gerrit.cloudera.org:8080/#/c/9960/1/be/src/codegen/llvm-codegen.cc File be/src/codegen/llvm-codegen.cc: http://gerrit.cloudera.org:8080/#/c/9960/1/be/src/codegen/llvm-codegen.cc@204 PS1, Line 204: CodegenTime > Yeah IrGenerationTime or something like that would be more accurate Done http://gerrit.cloudera.org:8080/#/c/9960/1/be/src/codegen/llvm-codegen.cc@216 PS1, Line 216: SCOPED_TIMER((*codegen)->profile_->total_time_counter()); : SCOPED_THREAD_COUNTER_MEASUREMENT((*codegen)->llvm_thread_counters()); > I think we should keep this consistent with CreateFromMemory() to minimise got it. I ll leave this in and remove the timer from LinkModuleFromLocalFs() -- To view, visit http://gerrit.cloudera.org:8080/9960 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I24d5a46b8870bc959b89045432d2e86af72b30e5 Gerrit-Change-Number: 9960 Gerrit-PatchSet: 2 Gerrit-Owner: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Wed, 11 Apr 2018 22:12:42 +0000 Gerrit-HasComments: Yes
