Hello Michael Ho, Tim Armstrong, I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9960 to look at the new patch set (#6). Change subject: IMPALA-6120: Add thread timers for reporting codegen time ...................................................................... IMPALA-6120: Add thread timers for reporting codegen time Add thread times for accurate reporting of codegen time. Also cleaned up a few places where time elapsed was being counted twice. Sample Profile: Query: SELECT count(*) FROM tpch_parquet.lineitem WHERE l_partkey in (1,6,11,16,21,26,31,36,41); CodeGen:(Total: 37.948ms, non-child: 37.948ms, % non-child: 100.00%) - CodegenInvoluntaryContextSwitches: 0 (0) - CodegenTotalWallClockTime: 37.942ms - CodegenSysTime: 0.000ns - CodegenUserTime: 36.938ms - CodegenVoluntaryContextSwitches: 0 (0) - CompileTime: 2.065ms - IrGenerationTime: 392.351us - LoadTime: 0.000ns - ModuleBitcodeSize: 2.26 MB (2373148) - NumFunctions: 22 (22) - NumInstructions: 381 (381) - OptimizationTime: 21.416ms - PeakMemoryUsage: 190.50 KB (195072) - PrepareTime: 13.496ms Sample Profile with an added 2 sec sleep time to "OptimizationTime": CodeGen:(Total: 2s037ms, non-child: 2s037ms, % non-child: 100.00%) - CodegenInvoluntaryContextSwitches: 0 (0) - CodegenTotalWallClockTime: 2s037ms - CodegenSysTime: 0.000ns - CodegenUserTime: 37.672ms - CodegenVoluntaryContextSwitches: 1 (1) - CompileTime: 2.032ms - IrGenerationTime: 386.948us - LoadTime: 0.000ns - ModuleBitcodeSize: 2.26 MB (2373148) - NumFunctions: 22 (22) - NumInstructions: 381 (381) - OptimizationTime: 2s023ms - PeakMemoryUsage: 190.50 KB (195072) - PrepareTime: 11.598ms Change-Id: I24d5a46b8870bc959b89045432d2e86af72b30e5 --- M be/src/codegen/llvm-codegen.cc M be/src/codegen/llvm-codegen.h M be/src/exec/hdfs-avro-scanner.cc M be/src/exec/hdfs-parquet-scanner.cc M be/src/exec/hdfs-scanner.cc M be/src/exec/partitioned-aggregation-node.cc M be/src/exec/select-node.cc M be/src/exec/text-converter.cc M be/src/runtime/fragment-instance-state.cc M be/src/runtime/tuple.cc M be/src/util/tuple-row-compare.cc 11 files changed, 30 insertions(+), 39 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/9960/6 -- To view, visit http://gerrit.cloudera.org:8080/9960 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I24d5a46b8870bc959b89045432d2e86af72b30e5 Gerrit-Change-Number: 9960 Gerrit-PatchSet: 6 Gerrit-Owner: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>