Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/9960 )
Change subject: IMPALA-6120: Add thread timers for reporting codegen time ...................................................................... Patch Set 5: Code-Review+2 (1 comment) Carrying over Tim's +2 http://gerrit.cloudera.org:8080/#/c/9960/4/be/src/codegen/llvm-codegen.h File be/src/codegen/llvm-codegen.h: http://gerrit.cloudera.org:8080/#/c/9960/4/be/src/codegen/llvm-codegen.h@758 PS4, Line 758: N_STA > Is OPEN a phase or a state? Not sure what terminology we use, or if we're c Turns out we do define states and this corresponds to "CODEGEN_START" state. See https://github.com/apache/impala/blob/818cd8fa2721cd8205b304563b728952bffc8b2f/be/src/runtime/fragment-instance-state.h#L186 -- To view, visit http://gerrit.cloudera.org:8080/9960 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I24d5a46b8870bc959b89045432d2e86af72b30e5 Gerrit-Change-Number: 9960 Gerrit-PatchSet: 5 Gerrit-Owner: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 12 Apr 2018 01:11:57 +0000 Gerrit-HasComments: Yes
