[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/20506 )
Change subject: IMPALA-12465: Unicode column name support ...................................................................... Patch Set 9: (3 comments) > Uploaded patch set 9. Ah, okay, I was trying different things yesterday to fix the failed job. http://gerrit.cloudera.org:8080/#/c/20506/5/tests/metadata/column-unicode.py File tests/metadata/column-unicode.py: http://gerrit.cloudera.org:8080/#/c/20506/5/tests/metadata/column-unicode.py@12 PS5, Line 12: > The constraint does make sense to avoid running it repeatedly when changing Ack http://gerrit.cloudera.org:8080/#/c/20506/8/tests/metadata/test_column_unicode.py File tests/metadata/test_column_unicode.py: http://gerrit.cloudera.org:8080/#/c/20506/8/tests/metadata/test_column_unicode.py@38 PS8, Line 38: self.run_test_case('QueryTest/unicode-column-name', vector, > This probably isn't necessary, and would still be covered by the default te Ack, changed. http://gerrit.cloudera.org:8080/#/c/20506/8/tests/metadata/test_column_unicode.py@40 PS8, Line 40: > I'm not convinced this does anything. You're not using get_shell_cmd. Okay cool, noted, I thought both line 39 and 40 are necessary for client protocols. -- To view, visit http://gerrit.cloudera.org:8080/20506 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1ad9d63ac1b9631a0f4a433798bd5109aa2ed718 Gerrit-Change-Number: 20506 Gerrit-PatchSet: 9 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 05 Dec 2023 05:39:46 +0000 Gerrit-HasComments: Yes
