Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20506 )
Change subject: IMPALA-12465: Unicode column name support ...................................................................... Patch Set 10: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/20506/5/tests/metadata/column-unicode.py File tests/metadata/column-unicode.py: http://gerrit.cloudera.org:8080/#/c/20506/5/tests/metadata/column-unicode.py@12 PS5, Line 12: > Ack Are you planning to add the constraint back? http://gerrit.cloudera.org:8080/#/c/20506/8/tests/metadata/test_column_unicode.py File tests/metadata/test_column_unicode.py: http://gerrit.cloudera.org:8080/#/c/20506/8/tests/metadata/test_column_unicode.py@38 PS8, Line 38: self.run_test_case('QueryTest/unicode-column-name', vector, > Ack, changed. Done http://gerrit.cloudera.org:8080/#/c/20506/8/tests/metadata/test_column_unicode.py@40 PS8, Line 40: > Okay cool, noted, I thought both line 39 and 40 are necessary for client pr Done -- To view, visit http://gerrit.cloudera.org:8080/20506 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1ad9d63ac1b9631a0f4a433798bd5109aa2ed718 Gerrit-Change-Number: 20506 Gerrit-PatchSet: 10 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 05 Dec 2023 17:16:33 +0000 Gerrit-HasComments: Yes
