Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20506 )
Change subject: IMPALA-12465: Unicode column name support ...................................................................... Patch Set 8: (4 comments) Your code was based on code that's 3 months out-of-date, so I rebased to pick up the bits necessary for the ARM pre-commit build. http://gerrit.cloudera.org:8080/#/c/20506/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20506/5//COMMIT_MSG@17 PS5, Line 17: > Noted, I've added a testing header. Ack http://gerrit.cloudera.org:8080/#/c/20506/5/tests/metadata/column-unicode.py File tests/metadata/column-unicode.py: http://gerrit.cloudera.org:8080/#/c/20506/5/tests/metadata/column-unicode.py@12 PS5, Line 12: > I've removed the constraints, we'll need some dimensions to run the tests f The constraint does make sense to avoid running it repeatedly when changing table_format doesn't change the test. http://gerrit.cloudera.org:8080/#/c/20506/8/tests/metadata/test_column_unicode.py File tests/metadata/test_column_unicode.py: http://gerrit.cloudera.org:8080/#/c/20506/8/tests/metadata/test_column_unicode.py@38 PS8, Line 38: create_exec_option_dimension(disable_codegen_options=[False, True])) This probably isn't necessary, and would still be covered by the default test dimensions in exhaustive mode. http://gerrit.cloudera.org:8080/#/c/20506/8/tests/metadata/test_column_unicode.py@40 PS8, Line 40: cls.ImpalaTestMatrix.add_dimension(create_client_protocol_no_strict_dimension()) I'm not convinced this does anything. You're not using get_shell_cmd. -- To view, visit http://gerrit.cloudera.org:8080/20506 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1ad9d63ac1b9631a0f4a433798bd5109aa2ed718 Gerrit-Change-Number: 20506 Gerrit-PatchSet: 8 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Mon, 04 Dec 2023 22:16:50 +0000 Gerrit-HasComments: Yes
