Wenzhe Zhou has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20754 )

Change subject: IMPALA-12595: Allow automatic removal of old logs from previous 
PID
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/20754/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/20754/2//COMMIT_MSG@17
PS2, Line 17: T
nit: low case


http://gerrit.cloudera.org:8080/#/c/20754/2//COMMIT_MSG@24
PS2, Line 24: custom_cluster_test_suite.py is modified to invoke
            : start-impala-cluster.py with 'log_rotation_match_pid' set to False
Why set it to false?



--
To view, visit http://gerrit.cloudera.org:8080/20754
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I599799e73f27f941a1d7f3dec0f40b4f05ea5ceb
Gerrit-Change-Number: 20754
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Kurt Deschler <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
Gerrit-Comment-Date: Tue, 05 Dec 2023 21:54:04 +0000
Gerrit-HasComments: Yes

Reply via email to