Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20754 )
Change subject: IMPALA-12595: Allow automatic removal of old logs from previous PID ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/20754/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20754/2//COMMIT_MSG@17 PS2, Line 17: t > nit: low case Done http://gerrit.cloudera.org:8080/#/c/20754/2//COMMIT_MSG@24 PS2, Line 24: : As a minimum exercesise for this new log rotation behavior, > Why set it to false? This patch will change the default log rotation behavior to ignore PID. We can't ignore PID in e2e tests for reason mentioned in commit message. So I tried to have custom cluster test suite to run with this new log rotation behavior (ignore PID), and I found it can run well except for few tests in test_breakpad.py. -- To view, visit http://gerrit.cloudera.org:8080/20754 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I599799e73f27f941a1d7f3dec0f40b4f05ea5ceb Gerrit-Change-Number: 20754 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Tue, 05 Dec 2023 23:20:28 +0000 Gerrit-HasComments: Yes
