Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20498 )
Change subject: IMPALA-12018: Consider runtime filter for cardinality reduction ...................................................................... Patch Set 14: (3 comments) http://gerrit.cloudera.org:8080/#/c/20498/14/fe/src/main/java/org/apache/impala/planner/Planner.java File fe/src/main/java/org/apache/impala/planner/Planner.java: http://gerrit.cloudera.org:8080/#/c/20498/14/fe/src/main/java/org/apache/impala/planner/Planner.java@498 PS14, Line 498: planCtx > Is there a reason you pass a PlannerContext instead of the reduction scale I'd like to follow precedent set by Planner.computeProcessingCost() and Planner.computeResourceReqs(). They all have PlannerContext as param and unpack query options that they need inside the method. Reading Frontend.createExecRequest() is also cleaner this way. http://gerrit.cloudera.org:8080/#/c/20498/14/fe/src/main/java/org/apache/impala/planner/ScanNode.java File fe/src/main/java/org/apache/impala/planner/ScanNode.java: http://gerrit.cloudera.org:8080/#/c/20498/14/fe/src/main/java/org/apache/impala/planner/ScanNode.java@569 PS14, Line 569: scanRangeSelectivity_ Learning from IMPALA-12510, think this should be capped to estimate that at least 1 scan range read is possible after filtering. http://gerrit.cloudera.org:8080/#/c/20498/14/fe/src/main/java/org/apache/impala/planner/ScanNode.java@578 PS14, Line 578: Math.round This should be ceil. -- To view, visit http://gerrit.cloudera.org:8080/20498 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I033789c9b63a8188484e3afde8e646563918b3e1 Gerrit-Change-Number: 20498 Gerrit-PatchSet: 14 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: David Rorke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 06 Dec 2023 19:52:34 +0000 Gerrit-HasComments: Yes
