Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20498 )
Change subject: IMPALA-12018: Consider runtime filter for cardinality reduction ...................................................................... Patch Set 17: (2 comments) http://gerrit.cloudera.org:8080/#/c/20498/16//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20498/16//COMMIT_MSG@12 PS16, Line 12: than > nit: than Done http://gerrit.cloudera.org:8080/#/c/20498/16/fe/src/main/java/org/apache/impala/planner/ExchangeNode.java File fe/src/main/java/org/apache/impala/planner/ExchangeNode.java: http://gerrit.cloudera.org:8080/#/c/20498/16/fe/src/main/java/org/apache/impala/planner/ExchangeNode.java@306 PS16, Line 306: getCardinality() > I found a potential issue in resource estimation of EXCHANGE node. ps17 store the reduced cardinality into separate filed instead of replacing cardinality_ and inputCardinality_ filed. Therefore, memory estimation remain the same before and after patch, even if this feature is enabled by default. -- To view, visit http://gerrit.cloudera.org:8080/20498 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I033789c9b63a8188484e3afde8e646563918b3e1 Gerrit-Change-Number: 20498 Gerrit-PatchSet: 17 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: David Rorke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Fri, 15 Dec 2023 18:14:12 +0000 Gerrit-HasComments: Yes
