Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20498 )
Change subject: IMPALA-12018: Consider runtime filter for cardinality reduction ...................................................................... Patch Set 15: (4 comments) http://gerrit.cloudera.org:8080/#/c/20498/14/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java: http://gerrit.cloudera.org:8080/#/c/20498/14/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@2003 PS14, Line 2003: estScanRangeAfterRuntimeFilter(), getEffectiveNumScanRanges())); > Spelling this out to number of scan range might be better. That way, user c Done http://gerrit.cloudera.org:8080/#/c/20498/14/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java File fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java: http://gerrit.cloudera.org:8080/#/c/20498/14/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java@812 PS14, Line 812: its > Nit: its. Done http://gerrit.cloudera.org:8080/#/c/20498/14/fe/src/main/java/org/apache/impala/planner/ScanNode.java File fe/src/main/java/org/apache/impala/planner/ScanNode.java: http://gerrit.cloudera.org:8080/#/c/20498/14/fe/src/main/java/org/apache/impala/planner/ScanNode.java@569 PS14, Line 569: long scanCardinalityA > Learning from IMPALA-12510, think this should be capped to estimate that at Done http://gerrit.cloudera.org:8080/#/c/20498/14/fe/src/main/java/org/apache/impala/planner/ScanNode.java@578 PS14, Line 578: > This should be ceil. Done -- To view, visit http://gerrit.cloudera.org:8080/20498 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I033789c9b63a8188484e3afde8e646563918b3e1 Gerrit-Change-Number: 20498 Gerrit-PatchSet: 15 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: David Rorke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 06 Dec 2023 20:32:51 +0000 Gerrit-HasComments: Yes
