[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/20791 )
Change subject: IMPALA-9375: Remove DirectMetaProvider usage from CatalogMetaProvider ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/20791/2/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java File fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java: http://gerrit.cloudera.org:8080/#/c/20791/2/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@1713 PS2, Line 1713: private static final String UNPARTITIONED_NAME = ""; > nit: unused? Used in checkLatestCompaction method. http://gerrit.cloudera.org:8080/#/c/20791/2/fe/src/main/java/org/apache/impala/service/JniCatalog.java File fe/src/main/java/org/apache/impala/service/JniCatalog.java: http://gerrit.cloudera.org:8080/#/c/20791/2/fe/src/main/java/org/apache/impala/service/JniCatalog.java@568 PS2, Line 568: MetaStoreUtil.getNullPartitionKeyValue(msClient.getHiveClient())); > I just realized this triggers HMS RPCs in our offline discussion. Will this HMS may be restarted with new "hive.exec.default.partition.name" value. I think, it is safe to fetch as and when needed. It is a lightweight operation. -- To view, visit http://gerrit.cloudera.org:8080/20791 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I096c1b1d1a52e979c8b2d8173dae9ca2cc6c36d2 Gerrit-Change-Number: 20791 Gerrit-PatchSet: 2 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Mon, 18 Dec 2023 06:32:14 +0000 Gerrit-HasComments: Yes
