Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20791 )
Change subject: IMPALA-9375: Remove DirectMetaProvider usage from CatalogMetaProvider ...................................................................... Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/20791/4/be/src/catalog/catalog-server.cc File be/src/catalog/catalog-server.cc: http://gerrit.cloudera.org:8080/#/c/20791/4/be/src/catalog/catalog-server.cc@368 PS4, Line 368: VLOG_RPC << "GetNullPartitionName(): request=" << ThriftDebugString(req); Please make sure you don't output sensitive data with ThriftDebugString(). If so, use impala::RedactedDebugString() instead. http://gerrit.cloudera.org:8080/#/c/20791/4/be/src/catalog/catalog-server.cc@377 PS4, Line 377: VLOG_RPC << "GetNullPartitionName(): response=" << ThriftDebugStringNoThrow(resp); Please make sure you don't output sensitive data with ThriftDebugString(). If so, use impala::RedactedDebugString() instead. http://gerrit.cloudera.org:8080/#/c/20791/4/be/src/catalog/catalog-server.cc@382 PS4, Line 382: VLOG_RPC << "GetLatestCompactions(): request=" << ThriftDebugString(req); Please make sure you don't output sensitive data with ThriftDebugString(). If so, use impala::RedactedDebugString() instead. http://gerrit.cloudera.org:8080/#/c/20791/4/be/src/catalog/catalog-server.cc@391 PS4, Line 391: VLOG_RPC << "GetLatestCompactions(): response=" << ThriftDebugStringNoThrow(resp); Please make sure you don't output sensitive data with ThriftDebugString(). If so, use impala::RedactedDebugString() instead. -- To view, visit http://gerrit.cloudera.org:8080/20791 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I096c1b1d1a52e979c8b2d8173dae9ca2cc6c36d2 Gerrit-Change-Number: 20791 Gerrit-PatchSet: 4 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Wed, 03 Jan 2024 11:30:12 +0000 Gerrit-HasComments: Yes
