[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/20791 )
Change subject: IMPALA-9375: Remove DirectMetaProvider usage from CatalogMetaProvider ...................................................................... Patch Set 4: (4 comments) Fixed review comments http://gerrit.cloudera.org:8080/#/c/20791/2/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java File fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java: http://gerrit.cloudera.org:8080/#/c/20791/2/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@743 PS2, Line 743: } > nit: don't need brackets "{}" for one-line statement. Done http://gerrit.cloudera.org:8080/#/c/20791/2/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@759 PS2, Line 759: for (CompactionInfoStruct ci : response.getCompactions()) { > nit: don't need brackets "{}" Done http://gerrit.cloudera.org:8080/#/c/20791/2/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java File fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java: http://gerrit.cloudera.org:8080/#/c/20791/2/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@1019 PS2, Line 1019: TGetLatestCompactionsResponse resp = new TGetLatestCompactionsResponse(); > It'd be helpful to keep logging the time taken for checking the latest comp Done http://gerrit.cloudera.org:8080/#/c/20791/2/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@1713 PS2, Line 1713: * Invalidate cached DataSource for the given DataSource name. If anything was > We can use HdfsTable.DEFAULT_PARTITION_NAME which is the name of default pa Done -- To view, visit http://gerrit.cloudera.org:8080/20791 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I096c1b1d1a52e979c8b2d8173dae9ca2cc6c36d2 Gerrit-Change-Number: 20791 Gerrit-PatchSet: 4 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Thu, 04 Jan 2024 06:16:54 +0000 Gerrit-HasComments: Yes
