Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20707 )
Change subject: IMPALA-12561: Event-processor shouldn't go into ERROR state for failures in fetching events ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/20707/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20707/3//COMMIT_MSG@15 PS3, Line 15: Callers can catch the exception and convert it : into MetastoreNotificationFetchException which won't fail the : event-processor. > nit: There are several places where getMetastoreClient() is called. This pa Good point. Previously we just looked into the codes of different event types. In MetastoreEventsProcessor we do need to catch the new exception in some other places. Added codes to catch the exception in getNextMetastoreEventsInBatches() and getEventTimeFromHMS(). getNextMetastoreEventsInBatches() already throws MetastoreNotificationFetchException (but not all its callers handle that). We can convert MetastoreClientInstantiationException to MetastoreNotificationFetchException. getEventTimeFromHMS() is introduced by a recent patch. It should catch MetastoreClientInstantiationException since it's used in the main loop of event-processor (i.e. in processEvents()) when fetching events. -- To view, visit http://gerrit.cloudera.org:8080/20707 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I775684d473fdbfb9f0531234f59a6239bd0873e3 Gerrit-Change-Number: 20707 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Fri, 22 Dec 2023 13:53:57 +0000 Gerrit-HasComments: Yes
