Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20707 )
Change subject: IMPALA-12561: Event-processor shouldn't go into ERROR state for failures in fetching events ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/20707/4/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java File fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java: http://gerrit.cloudera.org:8080/#/c/20707/4/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@3391 PS4, Line 3391: testHMSClientFailureInFetchingEvents nit: Should there be another FE test for getNextMetastoreEventsInBatches() and getEventTimeFromHMS()? -- To view, visit http://gerrit.cloudera.org:8080/20707 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I775684d473fdbfb9f0531234f59a6239bd0873e3 Gerrit-Change-Number: 20707 Gerrit-PatchSet: 4 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Fri, 22 Dec 2023 15:41:56 +0000 Gerrit-HasComments: Yes
