Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20707 )
Change subject: IMPALA-12561: Event-processor shouldn't go into ERROR state for failures in fetching events ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/20707/3/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java: http://gerrit.cloudera.org:8080/#/c/20707/3/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@1122 PS3, Line 1122: event.processIfEnabled(); > catalog_.getMetaStoreClient() throws MetastoreClientInstantiationException Yeah, that's a concern. Our goal is to survive in intermittent HMS errors. It could also happen in processing events. Note that previously catalog_.getMetaStoreClient() throws IllegalStateException which is also an unchecked exception. So the situation is not worse. The current patch set mainly deals with failures in fetching events. Agree that there are some retriable steps in processing events. But it requires a more complex change to catch MetastoreClientInstantiationException in those places and add appropriate retry codes. Do you think bumping the Hive configs of hive.metastore.connect.retries and hive.metastore.client.connect.retry.delay is enough? We might need to tolerate a failure duration of 5 minutes. -- To view, visit http://gerrit.cloudera.org:8080/20707 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I775684d473fdbfb9f0531234f59a6239bd0873e3 Gerrit-Change-Number: 20707 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Mon, 20 Nov 2023 08:53:08 +0000 Gerrit-HasComments: Yes
