Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/20853 )
Change subject: IMPALA-12670: getIfPresent should throw the cause of error ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/20853/2/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java File fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java: http://gerrit.cloudera.org:8080/#/c/20853/2/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@899 PS2, Line 899: } catch (ExecutionException e) { loadWithCaching() also catches UncheckedExecutionException at line 577 - is there a reason for the difference? http://gerrit.cloudera.org:8080/#/c/20853/2/tests/custom_cluster/test_local_catalog.py File tests/custom_cluster/test_local_catalog.py: http://gerrit.cloudera.org:8080/#/c/20853/2/tests/custom_cluster/test_local_catalog.py@475 PS2, Line 475: tls.c, "select * from {0}.tbl where p=0".format(unique_database)) nit: +2 indentation -- To view, visit http://gerrit.cloudera.org:8080/20853 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I74268ba2bb700988107780e13ffbdbb4c767d09d Gerrit-Change-Number: 20853 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 04 Jan 2024 15:54:29 +0000 Gerrit-HasComments: Yes
