Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20853 )
Change subject: IMPALA-12670: getIfPresent should throw the cause of error ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/20853/2/be/src/exec/catalog-op-executor.cc File be/src/exec/catalog-op-executor.cc: http://gerrit.cloudera.org:8080/#/c/20853/2/be/src/exec/catalog-op-executor.cc@60 PS2, Line 60: DEFINE_double_hidden(inject_failure_ratio_in_catalog_fetch, -1, This could be a debug action, but seems like we already have a pattern here you're following. http://gerrit.cloudera.org:8080/#/c/20853/2/be/src/exec/catalog-op-executor.cc@61 PS2, Line 61: "Ratio to randomly fail the GetPartialCatalogObject RPC with TABLE_NOT_LOADED " What's the allowed range for this ratio? And why default to -1 rather than 0? -- To view, visit http://gerrit.cloudera.org:8080/20853 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I74268ba2bb700988107780e13ffbdbb4c767d09d Gerrit-Change-Number: 20853 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 04 Jan 2024 19:24:31 +0000 Gerrit-HasComments: Yes
