Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20853 )
Change subject: IMPALA-12670: getIfPresent should throw the cause of error ...................................................................... Patch Set 2: (1 comment) I reread the original Guava issue (https://github.com/google/guava/issues/1881). Looks like even in Caffeine, invalidateAll still have undefined behavior even with AsyncLoadingCache. There is also a mention about Guava wrapper that forked out from Trino. Maybe we can consider that to simplify CatalogdMetaProvider cache. https://github.com/findepi/evictable-cache http://gerrit.cloudera.org:8080/#/c/20853/2/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java File fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java: http://gerrit.cloudera.org:8080/#/c/20853/2/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@899 PS2, Line 899: } catch (ExecutionException e) { > loadWithCaching() also catches UncheckedExecutionException at line 577 - is I think the UncheckedExecutionException is there because cache_.get() may throw it, besides of ExecutionException and ExecutionError. getUninterruptibly() in this try block can throw ExecutionException and CancellationException (a RuntimeException subclass). The latter will be wrapped again in line 903? -- To view, visit http://gerrit.cloudera.org:8080/20853 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I74268ba2bb700988107780e13ffbdbb4c767d09d Gerrit-Change-Number: 20853 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 04 Jan 2024 20:04:32 +0000 Gerrit-HasComments: Yes
