Hello Laszlo Gaal, Kurt Deschler, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21001
to look at the new patch set (#3).
Change subject: IMPALA-11568: Fix SamplingTimeSeriesCounter not correctly
cleared
......................................................................
IMPALA-11568: Fix SamplingTimeSeriesCounter not correctly cleared
TimeSeriesCounters are scheduled in PeriodicCounterUpdater at the time
when they are added. TimeSeriesCounterToJsonTest stops and clears them
to avoid the update thread interfere with the rest of the test. However,
the samples in SamplingTimeSeriesCounter are not cleared since it
doesn't implement the Clear() method of TimeSeriesCounter. This leads to
non-determined results depend on when the counter is stopped.
This patch adds the Clear() method for SamplingTimeSeriesCounter to
clear the samples. A Reset() method in StreamingSampler is added for
this purpose.
Test:
- Ran TimeSeriesCounterToJsonTest 1500 times.
Change-Id: I8bc2c94ad96899522b288708fcaf7413d4b99fa1
---
M be/src/util/runtime-profile-counters.h
M be/src/util/runtime-profile-test.cc
M be/src/util/runtime-profile.cc
M be/src/util/streaming-sampler.h
4 files changed, 22 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/01/21001/3
--
To view, visit http://gerrit.cloudera.org:8080/21001
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8bc2c94ad96899522b288708fcaf7413d4b99fa1
Gerrit-Change-Number: 21001
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Kurt Deschler <[email protected]>
Gerrit-Reviewer: Laszlo Gaal <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
