Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/21001 )
Change subject: IMPALA-11568: Fix SamplingTimeSeriesCounter not correctly cleared ...................................................................... Patch Set 3: Code-Review+2 (2 comments) I stand corrected; thanks for the explanation, Quanlong. I shouldn't be doing code reviews while skiing I guess :) http://gerrit.cloudera.org:8080/#/c/21001/1/be/src/util/streaming-sampler.h File be/src/util/streaming-sampler.h: http://gerrit.cloudera.org:8080/#/c/21001/1/be/src/util/streaming-sampler.h@49 PS1, Line 49: esets > 'initial_period_' keeps the parameter value we got from the constructor. It Done http://gerrit.cloudera.org:8080/#/c/21001/1/be/src/util/streaming-sampler.h@105 PS1, Line 105: Storage period > It's used to reset 'period_'. I'll add a comment. Done -- To view, visit http://gerrit.cloudera.org:8080/21001 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8bc2c94ad96899522b288708fcaf7413d4b99fa1 Gerrit-Change-Number: 21001 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Thu, 08 Feb 2024 14:14:02 +0000 Gerrit-HasComments: Yes
