Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21001 )
Change subject: IMPALA-11568: Fix SamplingTimeSeriesCounter not correctly cleared ...................................................................... Patch Set 4: (1 comment) Thank Laszlo for the quick review! Enjoy the vocation! Aborted the GVO job since I need to double check the impact on non-test codes. http://gerrit.cloudera.org:8080/#/c/21001/4/be/src/runtime/query-state.cc File be/src/runtime/query-state.cc: http://gerrit.cloudera.org:8080/#/c/21001/4/be/src/runtime/query-state.cc@568 PS4, Line 568: host_profile_->ClearChunkedTime This will now invoke SamplingTimeSeriesCounter::Clear(). It seems we just want to clear the ChunkedTimeSeriesCounters but keep the SamplingTimeSeriesCounters continues to do their work. -- To view, visit http://gerrit.cloudera.org:8080/21001 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8bc2c94ad96899522b288708fcaf7413d4b99fa1 Gerrit-Change-Number: 21001 Gerrit-PatchSet: 4 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Fri, 09 Feb 2024 00:10:22 +0000 Gerrit-HasComments: Yes
