Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21087 )
Change subject: IMPALA-12851: Fix AllocWriteIdEvent process issue to add txnId-tableWriteIds mapping ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/21087/2/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java File fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java: http://gerrit.cloudera.org:8080/#/c/21087/2/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@3694 PS2, Line 3694: } > I think, tests covered in test_events_custom_configs.py are enough for thes I might miss something. Do we already have tests in test_events_custom_configs.py that will fail without this fix? Or do you mean the new tests added in another patch? https://gerrit.cloudera.org/c/21065/ The motivation of adding test coverage is that when we backport this to older branches, we can run tests to verify the backport is correct. This save some cost of review on the backports. -- To view, visit http://gerrit.cloudera.org:8080/21087 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8b1a918befd4ee694880fd4e3cc04cb55b64955f Gerrit-Change-Number: 21087 Gerrit-PatchSet: 4 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Thu, 29 Feb 2024 23:48:33 +0000 Gerrit-HasComments: Yes
