Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21087 )
Change subject: IMPALA-12851: Fix AllocWriteIdEvent process issue to add txnId-tableWriteIds mapping ...................................................................... Patch Set 6: Code-Review+1 (4 comments) http://gerrit.cloudera.org:8080/#/c/21087/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21087/4//COMMIT_MSG@11 PS4, Line 11: 1 > In case-1, catalog table is not present because CREATE_TABLE event is not p thanks, it is clear now! http://gerrit.cloudera.org:8080/#/c/21087/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21087/6//COMMIT_MSG@17 PS6, Line 17: Can you mention reload event too? My understanding is that 1. was also relevant for it the patch fixed it. http://gerrit.cloudera.org:8080/#/c/21087/6//COMMIT_MSG@21 PS6, Line 21: Also fixed : a bug in TableWriteId's hashCode() implementation that is breaking : hashcode contract. Could this lead to correctness / perf issues? http://gerrit.cloudera.org:8080/#/c/21087/4/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/21087/4/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@2824 PS4, Line 2824: can b > Yes. Have added a TODO for now. This gerrit is required for https://gerrit. ack -- To view, visit http://gerrit.cloudera.org:8080/21087 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8b1a918befd4ee694880fd4e3cc04cb55b64955f Gerrit-Change-Number: 21087 Gerrit-PatchSet: 6 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Fri, 01 Mar 2024 17:31:37 +0000 Gerrit-HasComments: Yes
