Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21087 )
Change subject: IMPALA-12851: Fix AllocWriteIdEvent process issue to add txnId-tableWriteIds mapping ...................................................................... Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/21087/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21087/4//COMMIT_MSG@11 PS4, Line 11: 1 Isn't 1 a sub case of 2? After getting a CREATE_TABLE the table shouldn't be loaded yet. http://gerrit.cloudera.org:8080/#/c/21087/4/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/21087/4/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@3937 PS4, Line 3937: if (tbl.getNumClusteringCols() == 0) { Can you add a comment with some explanation (or some pointer to an explanation) about why this is only needed for partitioned tables? http://gerrit.cloudera.org:8080/#/c/21087/4/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@3938 PS4, Line 3938: LOG.debug("Not adding write ids to table {}.{} for event {} since it is " nit: missing "a"? http://gerrit.cloudera.org:8080/#/c/21087/4/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/21087/4/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@2824 PS4, Line 2824: msTbl_ Setting this member looks counter-intuitive to me in a property like function. A function like init() or lookupTable() could be added that is called before calling in processIfEnabled before isEventProcessingDisabled() and is a NOOP for other event types. -- To view, visit http://gerrit.cloudera.org:8080/21087 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8b1a918befd4ee694880fd4e3cc04cb55b64955f Gerrit-Change-Number: 21087 Gerrit-PatchSet: 4 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Fri, 01 Mar 2024 15:35:14 +0000 Gerrit-HasComments: Yes
