Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21100 )
Change subject: IMPALA-12864: Deflake test_query_log_size_in_bytes. ...................................................................... Patch Set 5: (12 comments) http://gerrit.cloudera.org:8080/#/c/21100/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21100/4//COMMIT_MSG@9 PS4, Line 9: build > Nit: builds. Done http://gerrit.cloudera.org:8080/#/c/21100/4//COMMIT_MSG@14 PS4, Line 14: d rel > Nit: relaxes. Done http://gerrit.cloudera.org:8080/#/c/21100/4//COMMIT_MSG@14 PS4, Line 14: simplifi > Nit: simplifies. Done http://gerrit.cloudera.org:8080/#/c/21100/4//COMMIT_MSG@15 PS4, Line 15: al > Nit: adds. Done http://gerrit.cloudera.org:8080/#/c/21100/4/be/src/util/impalad-metrics.h File be/src/util/impalad-metrics.h: http://gerrit.cloudera.org:8080/#/c/21100/4/be/src/util/impalad-metrics.h@264 PS4, Line 264: that > Nit: that are currently. Done http://gerrit.cloudera.org:8080/#/c/21100/4/common/thrift/metrics.json File common/thrift/metrics.json: http://gerrit.cloudera.org:8080/#/c/21100/4/common/thrift/metrics.json@2857 PS4, Line 2857: that are curre > Nit: that are currently. Done http://gerrit.cloudera.org:8080/#/c/21100/4/tests/custom_cluster/test_web_pages.py File tests/custom_cluster/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/21100/4/tests/custom_cluster/test_web_pages.py@173 PS4, Line 173: log_metric = metric > Could add a break here. Or do we reach this multiple times and we need the Done. There is only 1 entry. http://gerrit.cloudera.org:8080/#/c/21100/4/tests/custom_cluster/test_web_pages.py@174 PS4, Line 174: > Before writing the response text we could add some info about what's coming Done http://gerrit.cloudera.org:8080/#/c/21100/4/tests/custom_cluster/test_web_pages.py@178 PS4, Line 178: ric > Nit: the test queries. Done http://gerrit.cloudera.org:8080/#/c/21100/4/tests/custom_cluster/test_web_pages.py@178 PS4, Line 178: ric[" > Nit: the query page. Done http://gerrit.cloudera.org:8080/#/c/21100/4/tests/custom_cluster/test_web_pages.py@178 PS4, Line 178: 4, log > Nit: a subset. Done http://gerrit.cloudera.org:8080/#/c/21100/4/tests/custom_cluster/test_web_pages.py@180 PS4, Line 180: he query page only contai > The text is already parsed into JSON on L166, we could move this variable t This one is scraped from /queries page, while the one in L166 is scraped from /metrics page. Renamed the variable to clarify. -- To view, visit http://gerrit.cloudera.org:8080/21100 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic9b543ffa931a01c11d58e45774ea46af78b3a25 Gerrit-Change-Number: 21100 Gerrit-PatchSet: 5 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Mon, 04 Mar 2024 15:56:36 +0000 Gerrit-HasComments: Yes
