Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/21100 )
Change subject: IMPALA-12864: Deflake test_query_log_size_in_bytes. ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/21100/5/be/src/service/impala-server.h File be/src/service/impala-server.h: http://gerrit.cloudera.org:8080/#/c/21100/5/be/src/service/impala-server.h@1137 PS5, Line 1137: std::mutex query_log_lock_; > Agree. QUERY_LOG_EST_TOTAL_SIZE itself is already Atomic. Drop it from comm Thinking about this more, it is good that the QUERY_LOG_EST_TOTAL_SIZE metric is modified while this lock is held since that ensures this metric always matches the data stored in the query_log_est_sizes_ list. Please consider mentioning that modifications of this metric are done while this lock is held. http://gerrit.cloudera.org:8080/#/c/21100/5/common/thrift/metrics.json File common/thrift/metrics.json: http://gerrit.cloudera.org:8080/#/c/21100/5/common/thrift/metrics.json@2864 PS5, Line 2864: "key": "impala-server.query-log-est-total-size" Nit: The suffix "size" on the Impala metrics typically refers to a count of some sort and not to a specific number of bytes. I suggest naming this metric "impala-server.query-log-est-total-bytes". -- To view, visit http://gerrit.cloudera.org:8080/21100 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic9b543ffa931a01c11d58e45774ea46af78b3a25 Gerrit-Change-Number: 21100 Gerrit-PatchSet: 6 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Mon, 04 Mar 2024 20:27:22 +0000 Gerrit-HasComments: Yes
