Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21100 )
Change subject: IMPALA-12864: Deflake test_query_log_size_in_bytes. ...................................................................... Patch Set 6: (5 comments) http://gerrit.cloudera.org:8080/#/c/21100/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21100/5//COMMIT_MSG@14 PS5, Line 14: This patch simplifies the test query and relaxes the assertion. This > Nit: and relaxes the assertion Done http://gerrit.cloudera.org:8080/#/c/21100/5//COMMIT_MSG@15 PS5, Line 15: patch also adds QUERY_LOG_EST_TOTAL_SIZE metric (key name > Please mention the name of the new "impala-server.query-log-est-total-size" Done http://gerrit.cloudera.org:8080/#/c/21100/5/be/src/service/impala-server.h File be/src/service/impala-server.h: http://gerrit.cloudera.org:8080/#/c/21100/5/be/src/service/impala-server.h@1137 PS5, Line 1137: std::mutex query_log_lock_; > The lock does not protect the QUERY_LOG_EST_TOTAL_SIZE when it's being read Agree. QUERY_LOG_EST_TOTAL_SIZE itself is already Atomic. Drop it from comment. http://gerrit.cloudera.org:8080/#/c/21100/5/tests/custom_cluster/test_web_pages.py File tests/custom_cluster/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/21100/5/tests/custom_cluster/test_web_pages.py@153 PS5, Line 153: @CustomClusterTestSuite.with_args( > Nit: Since the (40 * 1024) calculation is used in two places, it would elim Done http://gerrit.cloudera.org:8080/#/c/21100/5/tests/custom_cluster/test_web_pages.py@178 PS5, Line 178: # 'should_exist' > The above code can be replaced with: Done. I'd like to keep the assertion separate so it is clear which expression is failed. -- To view, visit http://gerrit.cloudera.org:8080/21100 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic9b543ffa931a01c11d58e45774ea46af78b3a25 Gerrit-Change-Number: 21100 Gerrit-PatchSet: 6 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Mon, 04 Mar 2024 20:07:49 +0000 Gerrit-HasComments: Yes
