Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/9195 )
Change subject: IMPALA-6337: Fix infinite loop in Impala shell ...................................................................... Patch Set 11: > Patch Set 11: > > > Patch Set 11: > > > > > Do you know if this bug exists in 0.1.19? We've actually switched to > > > > that version elsewhere in the Impala python infra. > > > https://github.com/apache/impala/blob/master/infra/python/deps/requirements.txt#L65 > > > > Yes, the bug still exists in 0.1.19. However, depending how we use it, > > there may not be a real issue in Python infra. The infinite loop in Impala > > shell is a specific case because of the way we use sqlparse.split. > > Here's my concern. Work has already started on turning the impala-shell into > an actual python package for distributing through PyPI. See: > > https://gerrit.cloudera.org/c/9771/ > https://issues.apache.org/jira/browse/IMPALA-1071 > https://issues.apache.org/jira/browse/IMPALA-6808 > > With that change, we probably won't be relying on an internally-bundled > version of sqlparse anymore, especially if we're uploading impala-shell to > PyPI. Since we've hit several issues with sqlparse and upgrading may not be an easy option, do you think it's better to bundle our own sqlparse even with distributable impala-shell similar to how we deal with native-toolchain? -- To view, visit http://gerrit.cloudera.org:8080/9195 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9142f21a888189d351f00ce09baeba123bc0959b Gerrit-Change-Number: 9195 Gerrit-PatchSet: 11 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Thu, 03 May 2018 01:27:18 +0000 Gerrit-HasComments: No
