Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/9195 )
Change subject: IMPALA-6337: Fix infinite loop in Impala shell ...................................................................... Patch Set 11: > Patch Set 11: > > If there's a bug in sqlparse, have we filed it with sqlparse and tried to fix > it upstream? > > I think David's concern is with having patches rather than upgrading. I think > we can upgrade if we need to. Maintaining a "vendored"/shaded copy would be > annoying but also possible if we absolutely need the pathes. The fix is already upstream, but it's not released yet and it may require at minimum Python 2.7 for us to upgrade, which I don't know if it's an option for us. The sqlparse version that we use is pretty old. -- To view, visit http://gerrit.cloudera.org:8080/9195 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9142f21a888189d351f00ce09baeba123bc0959b Gerrit-Change-Number: 9195 Gerrit-PatchSet: 11 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Thu, 03 May 2018 21:45:47 +0000 Gerrit-HasComments: No
