David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9195 )
Change subject: IMPALA-6337: Fix infinite loop in Impala shell ...................................................................... Patch Set 12: (2 comments) > Patch Set 10: > > (2 comments) Since we're going ahead with this change, can you reply to this older comment? Do you think there's any merit to the idea of doing error checking in our own code and bailing with an error message, rather than shipping a patched version of sqlparse to workaround the issue? http://gerrit.cloudera.org:8080/#/c/9195/12/shell/ext-py/sqlparse-0.1.14/sqlparse/lexer.py File shell/ext-py/sqlparse-0.1.14/sqlparse/lexer.py: http://gerrit.cloudera.org:8080/#/c/9195/12/shell/ext-py/sqlparse-0.1.14/sqlparse/lexer.py@197 PS12, Line 197: Symbol I know you didn't change this part of the line, but do you know why this is String.Symbol, when the nearly identical line above specifies String.Single? http://gerrit.cloudera.org:8080/#/c/9195/9/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/9195/9/shell/impala_shell.py@601 PS9, Line 601: except AttributeError: > The problem seems to be in the stated assumption: "Error tokens are assumed Since we're going ahead with this change now, can you reply to this older comment? Do you think there's any merit to the idea of doing error checking in our own code and bailing with an error message, rather than shipping a patched version of sqlparse to workaround the issue? -- To view, visit http://gerrit.cloudera.org:8080/9195 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9142f21a888189d351f00ce09baeba123bc0959b Gerrit-Change-Number: 9195 Gerrit-PatchSet: 12 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Fri, 04 May 2018 21:37:52 +0000 Gerrit-HasComments: Yes
