Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10269 )
Change subject: IMPALA-6802 (part 2): Clean up authorization tests ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/10269/3/fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java File fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java: http://gerrit.cloudera.org:8080/#/c/10269/3/fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java@563 PS3, Line 563: .ok(onDatabase("functional", privilege)) : .ok(onTable("functional", "alltypes", privilege)) : .ok(onColumn("functional", "alltypes", "id", privilege)); I think the additional levels are unnecessary for default, but if they are then the privileges should be on default not functional. Or is the thinking that the default privileges might not work if there are any other privilege granted? http://gerrit.cloudera.org:8080/#/c/10269/3/fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java@573 PS3, Line 573: .ok(onDatabase("functional", privilege)) : .ok(onTable("functional", "alltypes", privilege)) : .ok(onColumn("functional", "alltypes", "id", privilege)); Same as above. -- To view, visit http://gerrit.cloudera.org:8080/10269 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ica5bfd2f12bf0cc8ebe78464a523a7805366f67b Gerrit-Change-Number: 10269 Gerrit-PatchSet: 3 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Adam Holley <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Comment-Date: Fri, 04 May 2018 01:12:55 +0000 Gerrit-HasComments: Yes
